This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix publish throttling and LoadManager API for pulsar upgrade #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
May 11, 2021
…native#488) This PR upgrades pulsar dependency to 2.8.0-rc-202105092228, which has two major API changes. apache/pulsar#10391 changed `LoadManager` API so that `MetadataCache` is used instead of `ZookeeperCache` in this PR. apache/pulsar#7406 changed the throttling strategy. However, currently KoP is different from Pulsar that the produce and its callback may be in different threads. KoP calls `PersistentTopic#publishMessages` in a callback of `KafkaTopicManager#getTopic` if the returned future is not completed immediately. Otherwise, it's called just in the I/O thread. Therefore, here we still use a **channel based** publish bytes stats for throttling, while apache/pulsar#7406 uses a **thread based** publish bytes stats. The other refactors are: 1. Change the throttling related fields from `InternalServerCnx` to `KafkaRequestHandler`. 2. Use `BrokerService#getPausedConnections` to check if the channel's auto read is disabled and modify the tests as well.
|
@jiazhai PTAL, it looks like the dependency from bintray is not available from now. See another PR's CI: https://github.com/streamnative/kop/pull/495/checks?check_run_id=2568314587
|
jiazhai
approved these changes
May 13, 2021
hangc0276
approved these changes
May 13, 2021
BewareMyPower
added a commit
that referenced
this pull request
Aug 18, 2021
### Motivation When there're a lot of topics, there could be a lot of `MetadataCache` instances in memory.  This bug was introduced from #488 because the Pulsar side adopted a new class `MetadataCache` as ZK cache. However, each time `MetadataStore#getMetadataCache` is called, a new `MetadataCache` instance will be created. In KoP, it means that each time a topic lookup is performed, a new `MetadataCache` instance will be created. ### Modifications Only call `MetadataStore#getMetadataCache` once when KoP starts and reuse the same `MetadataCache` instance for each `KafkaRequestHandler` instance.
BewareMyPower
added a commit
that referenced
this pull request
Aug 19, 2021
### Motivation When there're a lot of topics, there could be a lot of `MetadataCache` instances in memory.  This bug was introduced from #488 because the Pulsar side adopted a new class `MetadataCache` as ZK cache. However, each time `MetadataStore#getMetadataCache` is called, a new `MetadataCache` instance will be created. In KoP, it means that each time a topic lookup is performed, a new `MetadataCache` instance will be created. ### Modifications Only call `MetadataStore#getMetadataCache` once when KoP starts and reuse the same `MetadataCache` instance for each `KafkaRequestHandler` instance.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades pulsar dependency to 2.8.0-rc-202105092228, which has two major API changes.
apache/pulsar#10391 changed
LoadManagerAPI so thatMetadataCacheis used instead ofZookeeperCachein this PR.apache/pulsar#7406 changed the throttling strategy. However, currently KoP is different from Pulsar that the produce and its callback may be in different threads. KoP calls
PersistentTopic#publishMessagesin a callback ofKafkaTopicManager#getTopicif the returned future is not completed immediately. Otherwise, it's called just in the I/O thread. Therefore, here we still use a channel based publish bytes stats for throttling, while apache/pulsar#7406 uses a thread based publish bytes stats.The other refactors are:
InternalServerCnxtoKafkaRequestHandler.BrokerService#getPausedConnectionsto check if the channel's auto read is disabled and modify the tests as well.