This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Issue #61 : Fix unload and close broker error #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems original PR triggered github action. |
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Apr 24, 2023
gaoran10
pushed a commit
to gaoran10/kop
that referenced
this pull request
Jul 30, 2023
(cherry picked from commit 5ef4a85)
gaoran10
pushed a commit
to gaoran10/kop
that referenced
this pull request
Aug 9, 2023
(cherry picked from commit 5ef4a85)
gaoran10
pushed a commit
to gaoran10/kop
that referenced
this pull request
Aug 9, 2023
(cherry picked from commit 5ef4a85)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #61
We did not handle bundle unload very well. So in the situation that a topic is unload, the original kafka connection is still active, and topics still cached in KoP, this will cause error.
In this change, we track the topic loading status by register a mock producer in to PersistentTopic. when topic is unload, it will trigger the connection close.
Add new unit tests, make sure all tests passed.