feat(lock): support basic distributed lock api #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
coderzc
approved these changes
Sep 2, 2024
hangc0276
reviewed
Sep 2, 2024
client-api/src/main/java/io/streamnative/oxia/client/api/OptionBackoff.java
Outdated
Show resolved
Hide resolved
client-api/src/main/java/io/streamnative/oxia/client/api/OptionBackoff.java
Outdated
Show resolved
Hide resolved
| public CompletableFuture<Void> tryLock( | ||
| long time, TimeUnit unit, ExecutorService callbackService) { | ||
| return lock(callbackService) | ||
| .orTimeout(time, unit) |
There was a problem hiding this comment.
When lock with retry, and put the retry task into taskService queue and wait for the next time schedule, but the tryLock timeout condition hit. It will fail this trylock operation, but the next retry won't cancel and it may succeed.
There was a problem hiding this comment.
Yes, that's a good point. let me fix it then. :)
There was a problem hiding this comment.
I deleted the tryLock with time now. and will support safe cancel future in the next PR.
hangc0276
approved these changes
Sep 3, 2024
mattisonchao
added a commit
that referenced
this pull request
Sep 9, 2024
This reverts commit 3961ef4.
mattisonchao
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support basic APIs for distributed lock implementation. because it's still in experiment level, we can only use it by factory mode.