auth: support OIDC authentication provider and token authentication #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
tuteng
reviewed
Jun 26, 2024
| if _, ok := p.allowedAudiences[audience]; ok { | ||
| audienceAllowed = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you think it's necessary to check the permissions/scope field to verify the permissions?
There was a problem hiding this comment.
we don't support authorization yet. We can consider it when we support authorization. :)
tuteng
approved these changes
Jun 26, 2024
tuteng
reviewed
Jun 26, 2024
| const ( | ||
| MetadataAuthorizationKey = "authorization" | ||
| TokenPrefix = "Bearer " | ||
| ) |
There was a problem hiding this comment.
Maybe we should accept the header of authorizaiton/Authorizaiton and Bearer/bearer
There was a problem hiding this comment.
Okay, make sense. let me add it later. :)
There was a problem hiding this comment.
Sorry, the authorizaiton and Bearer should be standard. We can support leveraging case insensitivity in other PRs
tuteng
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should support some general authentication methods for the Oxia server for security concerns.
Modification
Next