Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): support notification retention configuration #515

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

mattisonchao
Copy link
Member

Motivation

the PR #353 remove the default configuration of notification retention. which causes unexpected behaviour when user uses oxia as metadata service.

especially for distributed lock. the revalidate after session expired will be never triggered.

the current value:

{"level":"info","time":"2024-09-18T07:11:48.692719842Z","config":{"PublicServiceAddr":"0.0.0.0:6648","InternalServiceAddr":"0.0.0.0:6649","PeerTLS":null,"ServerTLS":null,"InternalServerTLS":null,"MetricsServiceAddr":"0.0.0.0:8080","AuthOptions":{"ProviderName":"","ProviderParams":""},"DataDir":"/data/db","WalDir":"/data/wal","WalRetentionTime":3600000000000,"WalSyncData":true,"NotificationsRetentionTime":0,"DbBlockCacheMB":4096},"time":"2024-09-18T07:11:48.693399934Z","message":"Starting Oxia server"}

Modification

  • Add NotificationsRetentionTime back and the default time is 1 hour.

Others

We might need consider filter some notification on the server when user use oxia as some storage index service(high throughput of W/R) to avoid dispatching too much messages that will impact performance.

@merlimat merlimat merged commit f21df14 into main Sep 19, 2024
7 checks passed
@merlimat merlimat deleted the fix.notification branch September 19, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants