Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wal): Decoupled codec related logic #542

Merged
merged 11 commits into from
Oct 6, 2024
Merged

feat(wal): Decoupled codec related logic #542

merged 11 commits into from
Oct 6, 2024

Conversation

mattisonchao
Copy link
Member

Motivation

This PR introduces a codec component to help decouple the serialize/deserialize related logic.

Modification

  • Introduce the codec module with v1/v2 codec implementation.
  • reject append empty payload for wal
  • Moving codec related test to codec module

@mattisonchao mattisonchao self-assigned this Oct 5, 2024
@mattisonchao mattisonchao marked this pull request as ready for review October 5, 2024 08:32
@mattisonchao mattisonchao merged commit 17e653c into main Oct 6, 2024
7 checks passed
@mattisonchao mattisonchao deleted the crc.refactor branch October 6, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees

@mattisonchao mattisonchao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattisonchao @merlimat