Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-5922: On the dependencies in the pom.xml files. #13

Closed
sijie opened this issue Dec 26, 2019 · 4 comments
Closed

ISSUE-5922: On the dependencies in the pom.xml files. #13

sijie opened this issue Dec 26, 2019 · 4 comments
Labels

Comments

@sijie
Copy link
Member

sijie commented Dec 26, 2019

Original Issue: apache#5922


Describe the bug
Most of pom.xml files, in which some dependencies on the pulsar itself are written as following:
......
<dependency>
<groupId>org.apache.pulsar</groupId> // THIS LINE
<artifactId>pulsar------</artifactId>
<version>${project.version}</version>
</dependency>
......
But most of them are like this:
<dependency>
<groupId>${project.groupId}</groupId> // THIS LINE
<artifactId>pulsar------</artifactId>
<version>${project.version}</version>
</dependency>

Although both of them work, why not use JUST one of them (e.g. <groupId>${project.groupId}</groupId>).
pulsar-pom

@sijie sijie added help wanted Extra attention is needed triage/week-52 type/bug labels Dec 26, 2019
@lihanhui
Copy link

Hi Sijie, Let me make them unify.

@sijie
Copy link
Member Author

sijie commented Dec 27, 2019

@lihanhui sounds good. +1

@vcottagiri
Copy link

@sijie - can i can work on this?

@sijie
Copy link
Member Author

sijie commented Jul 2, 2020

@vcottagiri yes! You are welcome to make the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants