generated from streamnative/pulsar-io-template
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS s3 sink connector docs. #782
Merged
Merged
+206
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shibd:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
This pr needs to mark a document option in description
label
Oct 19, 2023
github-actions
bot
removed
the
doc-info-missing
This pr needs to mark a document option in description
label
Oct 19, 2023
@shibd:Thanks for providing doc info! |
RobertIndie
reviewed
Nov 6, 2023
Co-authored-by: Zike Yang <zike@apache.org>
RobertIndie
approved these changes
Nov 7, 2023
shibd
added a commit
that referenced
this pull request
Nov 10, 2023
* Add AWS s3 sink connector docs. * Update docs. * Update image * Apply suggestions from code review Co-authored-by: Zike Yang <zike@apache.org> --------- Co-authored-by: Zike Yang <zike@apache.org> (cherry picked from commit c246e94)
shibd
added a commit
that referenced
this pull request
Nov 10, 2023
* Add AWS s3 sink connector docs. * Update docs. * Update image * Apply suggestions from code review Co-authored-by: Zike Yang <zike@apache.org> --------- Co-authored-by: Zike Yang <zike@apache.org> (cherry picked from commit c246e94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The documentation for the current three connector cloud storage(aws-s3, Google Cloud Storage, Azure Blob Storage) is mixed together, which is not user-friendly and should be introduced separately for each cloud storage connector.
Modifications
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)