Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS s3 sink connector docs. #782

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Add AWS s3 sink connector docs. #782

merged 4 commits into from
Nov 8, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented Oct 19, 2023

Motivation

The documentation for the current three connector cloud storage(aws-s3, Google Cloud Storage, Azure Blob Storage) is mixed together, which is not user-friendly and should be introduced separately for each cloud storage connector.

Modifications

  • Add AWS S3 sink connector docs.

Verifying this change

  • None

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shibd shibd requested a review from a team as a code owner October 19, 2023 09:36
@github-actions
Copy link

@shibd:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 19, 2023
shibd added 2 commits October 19, 2023 17:43
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Oct 19, 2023
@github-actions
Copy link

@shibd:Thanks for providing doc info!

@shibd shibd requested a review from freeznet October 19, 2023 09:54
@github-actions github-actions bot added the doc This pr contains a document label Oct 19, 2023
@shibd shibd requested review from nlu90 and RobertIndie October 19, 2023 09:54
docs/aws-s3-sink.md Outdated Show resolved Hide resolved
docs/aws-s3-sink.md Show resolved Hide resolved
docs/aws-s3-sink.md Outdated Show resolved Hide resolved
docs/aws-s3-sink.md Outdated Show resolved Hide resolved
Co-authored-by: Zike Yang <zike@apache.org>
@shibd shibd requested a review from RobertIndie November 6, 2023 09:04
@shibd shibd merged commit c246e94 into streamnative:master Nov 8, 2023
2 checks passed
shibd added a commit that referenced this pull request Nov 10, 2023
* Add AWS s3 sink connector docs.

* Update docs.

* Update image

* Apply suggestions from code review

Co-authored-by: Zike Yang <zike@apache.org>

---------

Co-authored-by: Zike Yang <zike@apache.org>
(cherry picked from commit c246e94)
shibd added a commit that referenced this pull request Nov 10, 2023
* Add AWS s3 sink connector docs.

* Update docs.

* Update image

* Apply suggestions from code review

Co-authored-by: Zike Yang <zike@apache.org>

---------

Co-authored-by: Zike Yang <zike@apache.org>
(cherry picked from commit c246e94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants