-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes around service discovery, engine and consumer. #327
Open
FlorentinDUBOIS
wants to merge
9
commits into
streamnative:master
Choose a base branch
from
FlorentinDUBOIS:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
FlorentinDUBOIS
force-pushed
the
master
branch
from
December 19, 2024 10:29
e33ffba
to
a3e9b86
Compare
CleverAkanoa
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions regarding hazardous casting
…d topic Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
…egex for topic discovery Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
…ssage Co-authored-by: @Wonshtrum <eloi.demolis@clever-cloud.com> Co-authored-by: @KannarFr <alexandre.duval@clever-cloud.com> Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
FlorentinDUBOIS
force-pushed
the
master
branch
from
December 19, 2024 12:27
a3e9b86
to
ef7c063
Compare
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
CleverAkanoa
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining_messages
variable. The symptom was that consumer stop receiving messages, because they do not send any flow control message due to the invalid remaining message number. We also fix a bug that create a reconnect loop, because the driver consider that the newly created connection was already disconnected due to same origin.