Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imporve] fix scalastyle issues #127

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[imporve] fix scalastyle issues #127

merged 1 commit into from
Apr 12, 2023

Conversation

nlu90
Copy link
Collaborator

@nlu90 nlu90 commented Apr 12, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

mvn verify reported the following scala style issue:

error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/CachedConsumer.scala message=There should at least one a single empty line separating groups java and scala. line=17 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/CachedConsumer.scala message=There should at least one a single empty line separating groups scala and 3rdParty. line=18 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/CachedConsumer.scala message=There should at least one a single empty line separating groups 3rdParty and spark. line=22 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/CachedPulsarClient.scala message=There should at least one a single empty line separating groups 3rdParty and spark. line=26 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/PulsarHelper.scala message=There should at least one a single empty line separating groups 3rdParty and spark. line=33 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/PulsarSinks.scala message=There should at least one a single empty line separating groups 3rdParty and spark. line=22 column=0
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/PulsarSinks.scala message=SparkSession should come before SQLContext. line=23 column=28
error file=/home/runner/work/pulsar-spark/pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/PulsarSourceRDD.scala message=File line length exceeds 100 characters line=102

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nlu90 nlu90 self-assigned this Apr 12, 2023
@nlu90 nlu90 requested a review from a team as a code owner April 12, 2023 04:45
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Apr 12, 2023
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Although, I wonder if we have a CI workflow to guard this result. That is, we don't have such a CI workflow by GitHub Actions. I can see a Jenkins file but we don't require it in check state?

@nlu90
Copy link
Collaborator Author

nlu90 commented Apr 12, 2023

@tisonkun Yes, we need such a workflow to do a scala-style check.

Currently, these errors are reported during the release process.

@nlu90
Copy link
Collaborator Author

nlu90 commented Apr 12, 2023

#128 For future improvement

@nlu90 nlu90 merged commit fa13155 into master Apr 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the neng/fix-scalastyle-issue branch April 12, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants