Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop shading pulsar client and commons #140

Merged
merged 1 commit into from
Jul 25, 2023
Merged

stop shading pulsar client and commons #140

merged 1 commit into from
Jul 25, 2023

Conversation

nlu90
Copy link
Collaborator

@nlu90 nlu90 commented Jul 24, 2023

Motivation

  1. the authentication plugin config is full class name, that means we cannot shade these classes.
  2. Per: https://jlbp.dev/JLBP-18. We should not shade dependencies proactively.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@nlu90 nlu90 requested a review from a team as a code owner July 24, 2023 21:35
@nlu90 nlu90 self-assigned this Jul 24, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 24, 2023
chaoqin-li1123
chaoqin-li1123 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@chaoqin-li1123 chaoqin-li1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tisonkun tisonkun merged commit 9287f92 into master Jul 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the neng/update-shading-config branch July 25, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoqin-li1123 chaoqin-li1123 chaoqin-li1123 approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

@nlu90 nlu90

Labels
no-need-doc This pr does not need any document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlu90 @tisonkun @chaoqin-li1123