Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO_TICKET] fix: run spanner relational queries sequential to prevent seqno errors #10

Merged
merged 2 commits into from
Jul 4, 2023
Merged

[NO_TICKET] fix: run spanner relational queries sequential to prevent seqno errors #10

merged 2 commits into from
Jul 4, 2023

Conversation

Xevi
Copy link

@Xevi Xevi commented Jul 4, 2023

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@Xevi Xevi self-assigned this Jul 4, 2023
javierdelafuentesales
javierdelafuentesales approved these changes Jul 4, 2023
View reviewed changes
Copy link

@javierdelafuentesales javierdelafuentesales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xevi Xevi merged commit 5f88552 into main Jul 4, 2023
@Xevi Xevi deleted the NO_TICKET/investigate-seqno branch July 4, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierdelafuentesales javierdelafuentesales javierdelafuentesales approved these changes

@stephenarra stephenarra Awaiting requested review from stephenarra

@MuFa117 MuFa117 Awaiting requested review from MuFa117

@lee-hopin lee-hopin Awaiting requested review from lee-hopin

@monica-zha monica-zha Awaiting requested review from monica-zha

Assignees

@Xevi Xevi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xevi @javierdelafuentesales