-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOA-704] feat(app): Add Session Pool Options to the Spanner connection #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, were you able to test it?
I tested it locally and all was good :) (I updated the built code within node_modules) |
Shall we test it on staging-eu with real application? Before we merge this one?? |
@Xevi How do you test it on staging-eu without merging it? I think that first we need to get the new version. |
@Xevi merging this PR would still be fine until we bump up client’s version, so beta/prod is going to be fine, but I’m gonna bump the version on onair-api and deploy to staging-eu for sure if that’s what you were talking about |
We could always modify the action to make this branch to be able to get built. But should be fine if we are not using this version to anything in prod |
Description of change
Typeorm does not offer sessionPool options to be passed through the connection and uses the default ones. We would want to eventually control them from the client, so this would add this opportunity.
Options based on https://github.com/googleapis/nodejs-spanner/blob/main/src/session-pool.ts#L168
Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this changeFixes #0000