Added field level support for @Deprecated annotation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rahulreddym
commented
Oct 26, 2021
•
rahulreddym
commented
- Regenerated the well-know types for the CI tests to pass.
- The @deprecated annotation now includes empty message argument.
|
Looks like the CI test failed because your PR causes changes to the generated code that is bundled within pbandk. See https://github.com/streem/pbandk#bundled-types for instructions on how to re-generate that code. Add those changes to this PR and CI should pass. |
|
We should handle fields that are inside of a |
…nerated well-known types
garyp
requested changes
Oct 28, 2021
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
…file; common code cleanup.
garyp
approved these changes
Oct 29, 2021
protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/CodeGenerator.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.