Skip to content

Commit

Permalink
Fix missed symbol table entry creation for distributed builds (Bears-…
Browse files Browse the repository at this point in the history 
…R-Us#2733)

In Bears-R-Us#2653, the compatability shim was added to support the new
tryCreateArray throwing interface and that interface removed
initializers for block-distributed symbol table entries, replacing
with the new createSymEntry helper function. There were a few
instances of this missed in the KExtreme code, which was causing
distributed builds to fail.
  • Loading branch information
@bmcdonald3
bmcdonald3 authored Aug 29, 2023
1 parent d00e2ff commit 10f6d34
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions src/KExtremeMsg.chpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ module KExtremeMsg
when (DType.Int64) {
var e = toSymEntry(gEnt,int);
var aV = if !returnIndices then computeExtremaValues(e.a, k) else computeExtremaIndices(e.a, k);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand All @@ -59,14 +59,14 @@ module KExtremeMsg
var e = toSymEntry(gEnt,uint);
if !returnIndices {
var aV = computeExtremaValues(e.a, k);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
return new MsgTuple(repMsg, MsgType.NORMAL);
} else {
var aV = computeExtremaIndices(e.a, k);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand All @@ -77,14 +77,14 @@ module KExtremeMsg
var e = toSymEntry(gEnt,real);
if !returnIndices {
var aV = computeExtremaValues(e.a, k);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
return new MsgTuple(repMsg, MsgType.NORMAL);
} else {
var aV = computeExtremaIndices(e.a, k);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand Down Expand Up @@ -120,7 +120,7 @@ module KExtremeMsg
when (DType.Int64) {
var e = toSymEntry(gEnt,int);
var aV = if !returnIndices then computeExtremaValues(e.a, k, false) else computeExtremaIndices(e.a, k, false);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand All @@ -130,14 +130,14 @@ module KExtremeMsg
var e = toSymEntry(gEnt,uint);
if !returnIndices {
var aV = computeExtremaValues(e.a, k, false);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
return new MsgTuple(repMsg, MsgType.NORMAL);
} else {
var aV = computeExtremaIndices(e.a, k, false);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand All @@ -148,14 +148,14 @@ module KExtremeMsg
var e = toSymEntry(gEnt,real);
if !returnIndices {
var aV = computeExtremaValues(e.a, k, false);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
return new MsgTuple(repMsg, MsgType.NORMAL);
} else {
var aV = computeExtremaIndices(e.a, k, false);
st.addEntry(vname, new shared SymEntry(aV));
st.addEntry(vname, createSymEntry(aV));

repMsg = "created " + st.attrib(vname);
keLogger.debug(getModuleName(),getRoutineName(),getLineNumber(),repMsg);
Expand Down

0 comments on commit 10f6d34

Please sign in to comment.