Give mock.Anything its own type so it can't be mistaken for a string #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbravender
commented
Mar 22, 2021
dolmen
added
pkg-mock
|
Related: #1441 |
|
An alternate proposal: #1442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change makes
mock.Anythingits own typeChanges
mock.AnythingMotivation
While refactoring tests to use strongly typed
On_calls generated by mockery with this PR vektra/mockery#375 I started getting unexpected test failures because some tests were usingmock.Anythingwhere a string was expected and the functions were receiving"mock.Anything"as the parameter.mock.Anythingshould have its own type to make situations like this a compile-time error. I don't believe this change should affect existing tests that usemock.Anything.