Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install stride page #250

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Update install stride page #250

merged 1 commit into from
Feb 11, 2024

Conversation

Kryptos-FR
Copy link
Member

  • new screenshots based on latest version
  • change image format to WebP

Fixes first task of #219

@Kryptos-FR Kryptos-FR added content Docs content manual Related to manual documentation labels Feb 11, 2024
@VaclavElias
Copy link
Contributor

Thanks @Kryptos-FR.

This file install-stride.md, point 12. Shall we mention, that image is just for illustration purpose and it can be any latest .NET SDK, mentioned in prerequesites?

The bottom part Note needs to be fixed, probably there shouldn't be an empty line. Here are the examples: https://dotnet.github.io/docfx/docs/markdown.html?tabs=linux%2Cdotnet#alerts

image

@VaclavElias
Copy link
Contributor

And point 9, there is a typo pricay policy, should be privacy policy?

@Kryptos-FR
Copy link
Member Author

Fixing the typo and the note. I don't think we need to specify images are for illustration, it's kind of implicit.

- new screenshots based on latest version
- change image format to WebP
Copy link
Contributor

@VaclavElias VaclavElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I checked it on my PC and it seems all ok :)

@VaclavElias
Copy link
Contributor

I don't think we need to specify images are for illustration, it's kind of implicit.

That is true.

@VaclavElias VaclavElias merged commit f288a37 into master Feb 11, 2024
1 check passed
@Kryptos-FR Kryptos-FR deleted the update-install-guide branch February 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Docs content manual Related to manual documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants