This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
Fixed consumer fetch max wait time due to Sarama potential bug #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
To be cherry-picked on 0.3.0 release branch when merged. |
|
lgtm |
tombentley
approved these changes
Jun 1, 2022
ppatierno
added a commit
that referenced
this pull request
Jun 1, 2022
Signed-off-by: Paolo Patierno <ppatierno@live.com>
melchiormoulin
pushed a commit
to melchiormoulin/strimzi-canary
that referenced
this pull request
Jul 3, 2022
…zi#183) Signed-off-by: Paolo Patierno <ppatierno@live.com> Signed-off-by: Melchior Moulin <melchior.moulin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing RC2, we found that the end to end latency on the canary was increased.
After some investigation (thanks to @k-wall) it turned out that the following change in Sarama is the root cause: IBM/sarama#2227
It highlights that there could be a potential bug elsewhere in Sarama which has to be addressed.
Meanwhile, the canary can be updated by setting that consumer max time to the same 250 ms (as before in Sarama).
This PR fixes #184