Skip to content

Commit

Permalink
Removed unnecessary direct dep to OTel sdk-trace (#791)
Browse files Browse the repository at this point in the history
Signed-off-by: Paolo Patierno <ppatierno@live.com>
  • Loading branch information
ppatierno authored Apr 26, 2023
1 parent 33907ee commit 5bcb731
Showing 1 changed file with 6 additions and 16 deletions.
22 changes: 6 additions & 16 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -280,22 +280,6 @@
<artifactId>opentelemetry-exporter-otlp</artifactId>
<version>${opentelemetry.version}</version>
</dependency>
<!--
Not used directly in the bridge code but brought by Vert.x which is using a pretty old version (1.13.0)
OpenTelemetry also introduced a breaking change in the API (SdkTraceBuilder.build() method) starting from 1.17.0
Need to override to a more recent version
-->
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-trace</artifactId>
<version>${opentelemetry.version}</version>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-opentelemetry</artifactId>
<version>${vertx.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
<artifactId>micrometer-core</artifactId>
Expand Down Expand Up @@ -396,6 +380,12 @@
<version>${vertx.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-opentelemetry</artifactId>
<version>${vertx.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-common</artifactId>
Expand Down

0 comments on commit 5bcb731

Please sign in to comment.