Fix keycloak example + improve CI build to catch a similar issue next time #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
see-quick
reviewed
Oct 3, 2022
| @@ -14,4 +14,4 @@ services: | |||
| KEYCLOAK_PASSWORD: "admin" | |||
| KEYCLOAK_HTTPS_PORT: 8443 | |||
| PROXY_ADDRESS_FORWARDING: "true" | |||
| command: "-Dkeycloak.profile.feature.upload_scripts=enabled" | |||
| command: "-Dkeycloak.profile.feature.upload_scripts=enabled -b 0.0.0.0" | |||
There was a problem hiding this comment.
Shouldn't be 0.0.0.0 IP address the default one?
There was a problem hiding this comment.
Apparently the default one is some network interface with IP that is not accessible from other docker instances.
There was a problem hiding this comment.
That's for https, which is added extra via jboss-cli script. It's quite possible that there is a way to configure this in there, but adding -b 0.0.0.0 is simple enough for the test.
Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
Signed-off-by: Marko Strukelj <marko.strukelj@gmail.com>
scholzj
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.