-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OAuth scope optional #30
Conversation
Signed-off-by: klalafaryan <konstantin.lalafaryan@blacklane.com>
Signed-off-by: klalafaryan <konstantin.lalafaryan@blacklane.com>
Signed-off-by: klalafaryan <konstantin.lalafaryan@blacklane.com>
d55ff98
to
f0b29fd
Compare
The fix is in fact on the Kafka client (the client side of OAuth) - it doesn't really concern the Kafka Broker unless inter-broker communication goes over OAuth protected listener (which in Strimzi Kafka Operator it doesn't). I think adding the comment in the code is unnecessary, but overall the PR looks good. @klalafaryan Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but how are we going to test this?
@ppatierno I guess we won't test it immediately - the addressed situation never occurs in our current test setups (using Keycloak and Hydra). We could create simple authorization server endpoints that would do just enough so we can test this, eventually. |
@mstruk So we do not use the scope for anything in the broker part? |
@scholzj Correct. Authentication part does not use it - it's more for authorization use, but there SimpleACL isn't aware of it, and KeycloakRBACAuthorizer doesn't make use of it either - in favor of fine grained security provided by Authorization Services. |
Thanks for the PR. |
Some OAuth Authorization servers such as AWS Cognito don't provide the
scope
in the response. For example:This PR makes
scope
property optional which gives us possibility to integrate with AWS Cognito. (Authorization servers which are not providingscope
in the response)