Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabled remote debugging mode in example compose-authz.yml #39

Merged
merged 1 commit into from
Mar 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/docker/kafka-oauth-strimzi/compose-authz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ services:
- 9092:9092

# javaagent debug port
- 5006:5006
#- 5006:5006

environment:

# Java Debug
KAFKA_DEBUG: y
DEBUG_SUSPEND_FLAG: y
JAVA_DEBUG_PORT: 5006
#KAFKA_DEBUG: y
#DEBUG_SUSPEND_FLAG: y
#JAVA_DEBUG_PORT: 5006
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a comment like "uncomment following lines for enabling debugging ... "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be obvious to everyone that removing hashes would activate these settings.
And I prefer to not add comments for obvious things.


#
# KAFKA Configuration
Expand Down