Do not generate empty required arrays in OneOf definition

[scholzj]

Type of change

• Improvement

Description

Currently, we generate empty required arrays in the OneOf definitions in the CRDs. That seems to cause issues to some tools that do the diffing of the CRDs as Kubernetes seems to remove the empty arrays (see https://cloud-native.slack.com/archives/CMH3Q3SNP/p1724662526753129 as an example).

This PR adds a check and generates the arrays only if they have any values. This is what we already do for the required arrays in other places, so it should hopefully not cause any issues.

Checklist

• Make sure all tests pass
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[im-konge]

Thanks :)

[htolic]

Until 0.44.0 release, this can be added to ArgoCD Application resource:

  ignoreDifferences:
  - group: 'apiextensions.k8s.io'
    kind: CustomResourceDefinition
    jqPathExpressions:
    - '.spec.versions[]?.schema.openAPIV3Schema.properties.spec.properties[]?.properties[]?.properties[]?.properties.volumes.items.oneOf[]?.required'
    - '.spec.versions[]?.schema.openAPIV3Schema.properties.spec.properties[]?.properties[]?.properties.volumes.items.oneOf[]?.required'

[scholzj]

@htolic Thanks for sharing this, this might be useful for affected users 🤩

[jetersen]

@htolic much appreciated!