Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up of the test module #10526

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 31, 2024

Type of change

  • Refactoring

Description

This PR does a minor refactoring of the test module:

  • Removes the unused EmbeddedZooKeeper class
  • Moves CollectorElement to system tests where it is used
  • Updates LeaderElectionST to use the @IsolatedTest annotation from system tests and not from the test module => as all other system tests seem to use their own annotation
  • Updates the KafkaConnectApiIT class to not use the @IsolatedTest annotation as it does not run the tests in parallel in the first place
  • Addresses various IDE warnings in the TestUtils class (Including removing unused methods etc.)

Checklist

  • Make sure all tests pass

@scholzj scholzj added this to the 0.44.0 milestone Aug 31, 2024
@scholzj scholzj requested a review from a team August 31, 2024 21:22
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the minor-cleanup-of-the-test-module branch from 6bed515 to c46f544 Compare August 31, 2024 21:34
@scholzj
Copy link
Member Author

scholzj commented Aug 31, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 31, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 31, 2024

/azp run helm-acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit f137785 into strimzi:main Sep 1, 2024
27 checks passed
@scholzj scholzj deleted the minor-cleanup-of-the-test-module branch September 1, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants