Allow configuring advertised.listeners for controllers with Kafka version 3.9.0 #10530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaselenge
changed the title
tinaselenge
force-pushed
the
gate-3.9
branch
from
0387df3 to
dd0da6c
Compare
scholzj
reviewed
Sep 2, 2024
...tor/src/test/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilderTest.java
Outdated
Show resolved
Hide resolved
...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
…sion 3.9 Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
tinaselenge
force-pushed
the
gate-3.9
branch
from
dd0da6c to
306f08c
Compare
tinaselenge
changed the title
|
@scholzj should this PR wait until Kafka 3.9 is released or can it be pushed before that? I think it doesn't have to wait. |
|
@tinaselenge I think we can proceed with it. Let me run the regression. Can you mark it as ready for review if you don't plan any more changes? |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
thanks @scholzj. I've marked it as ready and regression tests passed. |
scholzj
reviewed
Sep 4, 2024
...perator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
When Kafka 3.9.0 is released and supported with Strimzi, the advertised.listeners will have to be configured for KRaft controllers, which is a forbidden configuration for the previous versions. While we still support an older version such as 3.8.0, we need to gate this configuration using the Kafka version.
Related issue: #10458.
Checklist
Please go through this checklist and make sure all applicable tasks have been done