Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current Raft state metric to the exported metrics #10533

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Sep 3, 2024

Type of change

  • Enhancement / new feature

Description

This PR adds the current raft state metric to the exported metrics. It lists the state of the Kafka node: leader, observer, follower etc. which seems like it might be useful.

Checklist

  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.44.0 milestone Sep 3, 2024
@scholzj scholzj requested a review from ppatierno September 3, 2024 21:28
@scholzj
Copy link
Member Author

scholzj commented Sep 3, 2024

@ppatierno This seemed useful to me. WDYT?

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it's useful thanks.
It would be also interesting to have it reflected on the Grafana dashboard.
See here for example, https://www.kineticedge.io/blog/kafka-raft/, the "Node State" table looks useful to me.

@scholzj
Copy link
Member Author

scholzj commented Sep 4, 2024

@ppatierno Yeah, that would make sense. I opened #10533 to add it to Grafana as well.

@scholzj scholzj merged commit fd74272 into strimzi:main Sep 4, 2024
13 checks passed
@scholzj scholzj deleted the add-current-raft-state-to-exported-kafka-metrics branch September 4, 2024 17:32
@ppatierno
Copy link
Member

@ppatierno Yeah, that would make sense. I opened #10533 to add it to Grafana as well.

@scholzj I guess you meant issue #10538 :-)

@scholzj
Copy link
Member Author

scholzj commented Sep 6, 2024

Yeah, sorry 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants