Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer only contents of Kafka and ZooKeeper properties files #76

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

MikeEdgar
Copy link
Contributor

I've been playing around with this library to investigate listener configurations (likely helpful to #63), but I am unable to run the tests in an environment with podman. It turns out that copying a MountableFile to the containers preserves the user and group Ids from the host machine via an intermediate tar file. This fails with podman due to the chown command not being allowed.

The change proposed here is to read the contents of the MountableFile prior to copying into the container. This drops the user and group information, which should not be relevant.

An additional change is to delay copying the Kafka properties until the container is starting, which allows for withKraft and withServerProperties to be called in any order.

Signed-off-by: Michael Edgar <medgar@redhat.com>
@scholzj scholzj requested a review from see-quick August 15, 2024 16:03
@see-quick see-quick added this to the 0.108.0 milestone Aug 19, 2024
@see-quick see-quick added the enhancement New feature or request label Aug 19, 2024
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@see-quick see-quick merged commit db8602e into strimzi:main Aug 19, 2024
7 checks passed
@MikeEdgar MikeEdgar deleted the transfer-bytes branch August 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants