Add KRaft readiness check in StrimziKafkaCluster #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
im-konge
approved these changes
Oct 16, 2024
Frawless
reviewed
Oct 16, 2024
src/main/java/io/strimzi/test/container/StrimziKafkaCluster.java
Outdated
Show resolved
Hide resolved
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Frawless
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a KRaft readiness check within
StrimziKafkaCluster. CurrentlywaitForRunning()inside eachStrimziKafkaContaineris not enough because it does not wait on Quorum form but only forTransitioning from RECOVERY to RUNNINGwhich is only correct when we use single-node. In case of multi-node we need to wait until quorum is formed and ready.