Remove Content-Length from HTTP Connect Custom response #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently while using HTTP Connect custom handlers it responds with content-length as 0 along with HTTP/1.0 200 OK. This is not RFC-9110 compliant which states that a server MUST NOT send any Transfer-Encoding or Content-Length header fields in a 2xx (Successful) response to CONNECT.
Old HTTP Connect Custom Response
New HTTP Connect Custom Response
Changes
We are setting ContentLength as -1 which marks it as unknown and removes content length while writing response
Snippet from Response Struct