-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DOT encoding support for internal/graph #70
Add DOT encoding support for internal/graph #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation here is good! I just have some small nits/tweaks.
Really cool set of changes!
Thanks for the feedback @bplunkett-stripe ! I just pushed my changes based on the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the changes! Only small change left is getting linting to pass.
Looks like linting isn't passing -- maybe I should allow anyone who posts a PR to run the workflows? In the interim, you can use make lint_fix
(you will need to install few things) or you could use this docker container to identify linting errors
I just did |
Nice! Let's hop back onto the ticket to figure out the structure of the CLI for this |
Description
This PR adds support for encoding the dependency graph to DOT format, which is used by Graphviz, a popular graph visualization software. This will allow us to visualize our dependency graphs for debugging purposes.
Motivation
Closes #38
Testing
resolveToSQLGraph()
, then manually visualized it using http://magjac.com/graphviz-visual-editor/ to verify the format's correctnessExample output:
I have a fresh new postgres instance and my target schema is this:
Based on the diffs and dependency graph, The DOT encoding will output: