Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify testing and update UUID format #86

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

bplunkett-stripe
Copy link
Collaborator

Description

  • Simplify testing. We have a bunch of test where we explicitly define the schema, but all we care about is asserting HOW the migration occurs. These were migrated to the "acceptance_tests", which are far less verbose
  • Update generated UUID's to be shorter

Motivation

Improve UX and project maintainability

Testing

Passes unit tests

@bplunkett-stripe bplunkett-stripe added the enhancement New feature or request label Jan 10, 2024
@bplunkett-stripe bplunkett-stripe force-pushed the bplunkett/simplify-testing branch from ad9ed4a to a124c98 Compare January 10, 2024 22:56
}

newNameSuffix := fmt.Sprintf("_%s", uuid.String())
prefix := fmt.Sprintf("%sidx_", tmpObjNamePrefix)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to use the canonical tmpObjectNamePrefix pgschemadiff_tmp and also the new base64 encoded UUID

@bplunkett-stripe bplunkett-stripe merged commit eff01bd into main Jan 11, 2024
6 checks passed
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/simplify-testing branch January 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants