Add support for fetching non-public schemas. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return concurrent.GetAll(ctx, tableFutures...) | ||
| } | ||
| tables = filterSliceByName( |
There was a problem hiding this comment.
It is way more flexible to do this filtering in-memory rather than in the query. We can easily support things like regex and complex nested operations in the future (unions of intersections, etc).
| @@ -25,8 +29,8 @@ LEFT JOIN | |||
| pg_catalog.pg_namespace AS parent_namespace | |||
| ON parent_c.relnamespace = parent_namespace.oid | |||
| WHERE | |||
| c.relnamespace | |||
| = (SELECT oid FROM pg_catalog.pg_namespace WHERE nspname = 'public') | |||
| table_namespace.nspname NOT IN ('pg_catalog', 'information_schema') | |||
There was a problem hiding this comment.
This is the same filter Postgres uses in its pg_stat_user_tables view to filter down from pg_stat_all_tables.
bplunkett-stripe
force-pushed
the
bplunkett/fetch-non-public-schemas
branch
from
970ecbc to
9863ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This only adds support for fetching non-public schemas. This does actually allow generating migration plans for non-public schemas because we will need plumb several into the sql generation code to account for schemas.
I opted to do the filtering in-memory because it is way more flexible to do the filtering in-memory rather than in the queries. We can easily support things like regex and complex nested operations in the future (unions of intersections, etc). I don't expect the filters to significantly reduce the number of schema objects being fetched, so the performance impact of doing it in-memory is minimal.
Motivation
#94
Testing
Tested via unit tests