Remove cart Element #487
Merged
Remove cart Element #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `mounts <${displayName}>`, | ||
| 'customCheckoutSdk' in ctx | ||
| ); | ||
| useElementsOrCustomCheckoutSdkContextWithUseCase(`mounts <${displayName}>`); |
There was a problem hiding this comment.
@pololi-stripe mind double-checking my change here and ensure Custom Checkout is still going to be happy? I don't suspect there is an issue, but erring on the side of caution with the ping.
awalker-stripe
approved these changes
Mar 29, 2024
| @@ -122,26 +105,6 @@ const createElementComponent = ( | |||
|
|
|||
| useAttachEvent(element, 'ready', readyCallback); | |||
|
|
|||
| const changeCallback = | |||
| type === 'cart' | |||
There was a problem hiding this comment.
it's cool that we can clean up these conditionals!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Cart Element is deprecated for now - helping clarify this by removing interfaces & types.
Testing & documentation
Cleaned up test references, and existing tests continue to pass