Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct invalid react version constraint #555

Merged

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Dec 13, 2024

The version constraint was invalid and accepted any react version >=16.8.0.

> import semver from "npm:semver"
> semver.satisfies("21.0.1", ">=16.8.0 && <=^19.0.0", { loose: true })
true

Copy link

cla-assistant bot commented Dec 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Dec 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Dec 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bombillazo
Copy link

bombillazo commented Dec 13, 2024

Thanks @dsherret ! Hopefully the Stripe team can take a quick look at this.

Copy link
Contributor

@dodgez-stripe dodgez-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@dodgez-stripe dodgez-stripe merged commit 45f1f56 into stripe:master Dec 13, 2024
2 checks passed
@dsherret dsherret deleted the fix_invalid_version_constraint branch December 13, 2024 19:14
@dodgez-stripe
Copy link
Contributor

Package version 3.1.1 contains this fix: https://www.npmjs.com/package/@stripe/react-stripe-js/v/3.1.1

@dsherret
Copy link
Contributor Author

Great, thanks!

@rado-stripe
Copy link
Contributor

👋 Hi David, thanks for the bug report!

@dsherret
Copy link
Contributor Author

@rado-stripe hey Rado, hope you've been doing well. No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants