Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goproxy version to incorporate CONNECT proxy header changes #215

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

pspieker-stripe
Copy link
Contributor

@pspieker-stripe pspieker-stripe commented Feb 16, 2024

Ran:

go get github.com/stripe/goproxy
go mod vendor

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7936136701

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.153%

Totals Coverage Status
Change from base Build 7935256831: 0.0%
Covered Lines: 1299
Relevant Lines: 2090

💛 - Coveralls

Copy link
Collaborator

@jjiang-stripe jjiang-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -12,7 +12,7 @@ require (
github.com/rs/xid v1.2.1
github.com/sirupsen/logrus v1.9.0
github.com/stretchr/testify v1.8.0
github.com/stripe/goproxy v0.0.0-20231113215313-dbbdf2f6d709
github.com/stripe/goproxy v0.0.0-20231206175114-560c3ba6a2a1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches master: stripe/goproxy@560c3ba

@pspieker-stripe pspieker-stripe merged commit 065ad0e into master Feb 16, 2024
3 of 5 checks passed
@pspieker-stripe pspieker-stripe deleted the bump-gp-version branch February 16, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants