Fix --forward-connect-to not forwarding events #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcheung-stripe
deleted the
vcheung/fix-forward-connect-to-not-forwarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @stripe/developer-products
cc @stripe/developer-products
Summary
Fix a bug where running
stripe listenwith--forward-connect-towould not forward events.Before:
Using
--forward-to <url>only:✅ direct events are forwarded to
<url>✅ connect events are forwarded to
<url>Using both
--forward-to <url 1>and--forward-connect-to <url 2>:✅ direct events are forwarded to
<url 1>✅ connect events are forwarded to
<url 2>Using
--forward-connect-to <url>only:✅ direct events are NOT forwarded to
<url>❌ connect events are NOT forwarded to
<url>After:
Using
--forward-to <url>only:✅ direct events are forwarded to
<url>✅ connect events are forwarded to
<url>Using both
--forward-to <url 1>and--forward-connect-to <url 2>:✅ direct events are forwarded to
<url 1>✅ connect events are forwarded to
<url 2>Using
--forward-connect-to <url>only:✅ direct events are NOT forwarded to
<url>✅ connect events are forwarded to
<url>I added unit tests for each of these and tested manually as well.