Polish UI Components for AU BECS (#892)

stripe · Mar 23, 2022 · 6915c6d · 6915c6d
1 parent 82810fd
commit 6915c6d
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 7 deletions.
diff --git a/Stripe/PaymentSheetFormFactory.swift b/Stripe/PaymentSheetFormFactory.swift
@@ -134,7 +134,15 @@ extension PaymentSheetFormFactory {
             return params
         }
     }
-
+
+    func makeNameOnAccount() -> PaymentMethodElementWrapper<TextFieldElement> {
+        let element = TextFieldElement.Address.makeNameOnAccount(defaultValue: configuration.defaultBillingDetails.name)
+        return PaymentMethodElementWrapper(element) { textField, params in
+            params.paymentMethodParams.nonnil_billingDetails.name = textField.text
+            return params
+        }
+    }
+
     func makeBSB() -> PaymentMethodElementWrapper<TextFieldElement> {
         let element = TextFieldElement.Account.makeBSB(defaultValue: nil)
         return PaymentMethodElementWrapper(element) { textField, params in
@@ -346,7 +354,7 @@ extension PaymentSheetFormFactory {
 
     func makeAUBECSDebit() -> [PaymentMethodElement] {
         let mandate = StaticElement(view: AUBECSLegalTermsView())
-        return [makeBSB(), makeAUBECSAccountNumber(), makeEmail(), makeFullName(), mandate]
+        return [makeBSB(), makeAUBECSAccountNumber(), makeEmail(), makeNameOnAccount(), mandate]
     }
 
     func makeAffirm() -> [PaymentMethodElement] {

diff --git a/Stripe/Resources/Localizations/en.lproj/Localizable.strings b/Stripe/Resources/Localizations/en.lproj/Localizable.strings
@@ -52,7 +52,7 @@
 "Apt." = "Apt.";
 
 /* Payment Method type brand name. */
-"AU BECS Debit" = "AU BECS Debit";
+"AU BECS Direct Debit" = "AU BECS Direct Debit";
 
 /* Text for back button */
 "Back" = "Back";

diff --git a/Stripe/STPPaymentMethodEnums.swift b/Stripe/STPPaymentMethodEnums.swift
@@ -82,7 +82,7 @@ import Foundation
         case .SEPADebit:
             return STPLocalizedString("SEPA Debit", "Payment method brand name")
         case .AUBECSDebit:
-            return STPLocalizedString("AU BECS Debit", "Payment Method type brand name.")
+            return STPLocalizedString("AU BECS Direct Debit", "Payment Method type brand name.")
         case .grabPay:
             return STPLocalizedString("GrabPay", "Payment Method type brand name.")
         case .giropay:

diff --git a/StripeUICore/StripeUICore/Resources/Localizations/en.lproj/Localizable.strings b/StripeUICore/StripeUICore/Resources/Localizations/en.lproj/Localizable.strings
@@ -81,6 +81,9 @@ Label of an address field */
 /* Label for Name field on form */
 "Name" = "Name";
 
+/* Label for Name on account field on form */
+"Name on account" = "Name on account";
+
 /* Label of an address field */
 "Oblast" = "Oblast";
 

diff --git a/StripeUICore/StripeUICore/Source/Elements/Factories/TextFieldElement+AddressFactory.swift b/StripeUICore/StripeUICore/Source/Elements/Factories/TextFieldElement+AddressFactory.swift
@@ -20,7 +20,7 @@ import UIKit
 
         public struct NameConfiguration: TextFieldElementConfiguration {
             @frozen public enum NameType {
-                case given, family, full
+                case given, family, full, onAccount
             }
 
             let type: NameType
@@ -34,6 +34,8 @@ import UIKit
                     return String.Localized.family_name
                 case .full:
                     return String.Localized.name
+                case .onAccount:
+                    return String.Localized.nameOnAccount
                 }
             }
             private var textContentType: UITextContentType {
@@ -42,7 +44,7 @@ import UIKit
                     return .givenName
                 case .family:
                     return .familyName
-                case .full:
+                case .full, .onAccount:
                     return .name
                 }
             }
@@ -60,7 +62,10 @@ import UIKit
         public static func makeFullName(defaultValue: String?) -> TextFieldElement {
             return TextFieldElement(configuration: NameConfiguration(type: .full, defaultValue: defaultValue))
         }
-
+
+        public static func makeNameOnAccount(defaultValue: String?) -> TextFieldElement {
+            return TextFieldElement(configuration: NameConfiguration(type: .onAccount, defaultValue: defaultValue))
+        }
         // MARK: - Email
 
         struct EmailConfiguration: TextFieldElementConfiguration {

diff --git a/StripeUICore/StripeUICore/Source/Helpers/String+Localized.swift b/StripeUICore/StripeUICore/Source/Helpers/String+Localized.swift
@@ -54,6 +54,10 @@ import Foundation
         STPLocalizedString("Last", "Label for last (family) name field")
     }
 
+    static var nameOnAccount: String {
+        STPLocalizedString("Name on account", "Label for Name on account field on form")
+    }
+
     static var invalid_email: String {
         STPLocalizedString("Your email is invalid.", "Error message when email is invalid")
     }