Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Resources Size #1630

Closed
clementpadovani opened this issue Aug 20, 2020 · 4 comments
Closed

SDK Resources Size #1630

clementpadovani opened this issue Aug 20, 2020 · 4 comments
Labels
fixed in master Fixed in master, awaiting next update triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@clementpadovani
Copy link

Summary

Hey, this isn’t a bug per se but a general inquiry.

I’m inspecting my application prior to shipping it and found that your resources (namely Stripe.bundle) weigh almost a hefty megabyte.

You bundle 148 images which aren’t part of your asset catalog, thus these images get bundled despite App Thinning.

Is there a specific reason as to why these aren’t part of an asset catalog?

Moreover, my app will only ship with a single localization (and work in a single market) and I haven’t set CFBundleAllowMixedLocalizations, do you see any objections as to deleting unnecessary localizations?

Thanks,

Code to reproduce

N/A

iOS version

N/A

Installation method

Cocoapods

SDK version

19.4.0

Other information

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Aug 31, 2020
@davidme-stripe
Copy link
Contributor

davidme-stripe commented Aug 31, 2020

Thanks for the feedback! We're looking into this and other ways to shrink our SDK for App Clips, and we hope to have an update soon.

In the meantime, I don't see any problem with deleting the unused localizations in your own app. It should save you ~75kb compressed.

@davidme-stripe
Copy link
Contributor

Fixed in #1643, which is in master. We'll get a release out soon.

@davidme-stripe davidme-stripe added the fixed in master Fixed in master, awaiting next update label Sep 12, 2020
@davidme-stripe
Copy link
Contributor

This is fixed in SDK 20.0.0.

@clementpadovani
Copy link
Author

thanks @davidme-stripe!

One last question regarding the bundled localization assets.

I’m guessing that those bundled in Stripe3DS2.bundle are related to 3DS authentication.

Do you enforce the localization based on the card’s region or is it device-based?

Basically, can I safely delete the superfluous regions there too?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in master Fixed in master, awaiting next update triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

2 participants