Remove iOS 10 support, update Stripe3DS2 #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe-ios into davidme/drop-ios-10-open-ssl
csabol-stripe
approved these changes
Sep 11, 2020
| #if !(defined(TARGET_OS_MACCATALYST) && (TARGET_OS_MACCATALYST != 0)) | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-implementations" | ||
| #pragma clang diagnostic ignored "-Wdeprecated" | ||
|
|
||
| - (void)paymentAuthorizationViewController:(PKPaymentAuthorizationViewController *)controller |
There was a problem hiding this comment.
maybe leave a note about removing when we drop iOS 11
| * derivative of this code cannot be changed. i.e. this code cannot simply be | ||
| * copied and put under another distribution licence | ||
| * [including the GNU Public Licence.] | ||
| */ |
This was referenced Sep 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for iOS 10 and update to the latest Stripe3DS2.
Motivation
Significantly shrinks the size of Stripe.framework.
Testing
Tested on device and in CI as part of #1633