Fixes hidden text fields from being read by VoiceOver #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using alpha instead of the hidden property for text fields we aren't displaying (so we can animate), we need to manually mark our hidden text fields as not an accessibility element. Otherwise VoiceOver thinks they are valid UI elements.
danj-stripe
approved these changes
Aug 11, 2018
There was a problem hiding this comment.
Great find!
I'm pretty surprised. I thought that alpha = 0 behaved the same as hidden = YES: https://stackoverflow.com/a/8229779/1196205
I wonder if we have any other places where this'll be a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are using alpha instead of the hidden property for text fields we aren't displaying (so we can animate),
we need to manually mark our hidden text fields as not an accessibility element. Otherwise VoiceOver thinks they are
valid UI elements.
Motivation
https://jira.corp.stripe.com/browse/IOS-602
Testing
Tested on device with VoiceOver