Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Rename "payment method" to "payment option" #1139

Merged
merged 11 commits into from
Mar 7, 2019

Conversation

yuki-stripe
Copy link
Collaborator

@yuki-stripe yuki-stripe commented Mar 5, 2019

Summary & Motivation

This change precedes adding PaymentMethod. Unfortunately, we already have a type that collides with this name, so I'm renaming it all to PaymentOption.

I've opted to aggressively rename most all references to 'payment method' - this means possibly more work for users to upgrade, but will make the upcoming usage of PaymentMethod clear and consistent.

Testing

All StripeIOS Tests pass, all projects build.

@yuki-stripe
Copy link
Collaborator Author

Should I update MIGRATING.md in this commit as well?

Copy link
Contributor

@bg-stripe bg-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! A couple requests:

  1. Let's update STPSDKVersion in STPAPIClient.h to 15.0.0 (major version update, since this is a breaking change). We should also update the version in the Info.plist.

  2. Looks like there are references to an example backend tag called v14.0.0. That reminds me that we'll probably need to cut a new example backend version, v15.0.0 as part of this release (currently the backend creates a charge with a source). cc @mshafrir-stripe

  3. Let's add a new changelog entry in CHANGELOG.md for 15.0.0 (maybe leaving a todo for the release date), and describe the breaking changes here. It's much easier to add changelog entries for breaking changes as part of incremental PRs, rather than going back later.

Example/UI Examples/BrowseViewController.swift Outdated Show resolved Hide resolved
Stripe/PublicHeaders/STPApplePay.h Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned yuki-stripe and unassigned bg-stripe Mar 5, 2019
@bg-stripe
Copy link
Contributor

Should I update MIGRATING.md in this commit as well?

@yuki-stripe ah yeah good call, let's do that too.

…sViewControllerLocalizationTests in the ignore list
Copy link
Contributor

@bg-stripe bg-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yuki-stripe yuki-stripe merged commit a3aae1a into master Mar 7, 2019
@yuki-stripe yuki-stripe deleted the yuki-rename-paymentmethod branch March 7, 2019 18:21
yuki-stripe pushed a commit that referenced this pull request May 31, 2022
* Use publishable key for 3DS2 fingerprint auth, if provided

* Cleanup

* Rename parameter

Co-authored-by: Cameron <36750494+csabol-stripe@users.noreply.github.com>

* Rename action property and fix build

* Fix test

Co-authored-by: Cameron <36750494+csabol-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants