-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Rename "payment method" to "payment option" #1139
Conversation
…STPPaymentOptionType, STPApplePayPaymentMethod -> STPApplePay
Should I update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! A couple requests:
-
Let's update
STPSDKVersion
inSTPAPIClient.h
to15.0.0
(major version update, since this is a breaking change). We should also update the version in theInfo.plist
. -
Looks like there are references to an example backend tag called
v14.0.0
. That reminds me that we'll probably need to cut a new example backend version,v15.0.0
as part of this release (currently the backend creates a charge with asource
). cc @mshafrir-stripe -
Let's add a new changelog entry in
CHANGELOG.md
for15.0.0
(maybe leaving a todo for the release date), and describe the breaking changes here. It's much easier to add changelog entries for breaking changes as part of incremental PRs, rather than going back later.
@yuki-stripe ah yeah good call, let's do that too. |
ed93b8e
to
22bae03
Compare
…sViewControllerLocalizationTests in the ignore list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* Use publishable key for 3DS2 fingerprint auth, if provided * Cleanup * Rename parameter Co-authored-by: Cameron <36750494+csabol-stripe@users.noreply.github.com> * Rename action property and fix build * Fix test Co-authored-by: Cameron <36750494+csabol-stripe@users.noreply.github.com>
Summary & Motivation
This change precedes adding
PaymentMethod
. Unfortunately, we already have a type that collides with this name, so I'm renaming it all to PaymentOption.I've opted to aggressively rename most all references to 'payment method' - this means possibly more work for users to upgrade, but will make the upcoming usage of PaymentMethod clear and consistent.
Testing
All StripeIOS Tests pass, all projects build.