Update for mid-Feb API changes #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
changed the base branch from
yuki-add-wallet-ideal-present-2
to
master
…aymentIntentsStatusRequiresPaymentMethod`
…tIntentStatusRequiresAction`
…uthorizeWithURL -> STPPaymentIntentAction, STPPaymentIntentActionRedirectToURL
yuki-stripe
force-pushed
the
yuki-api-updates
branch
from
053164e
to
bf8b410
Compare
…tStatusRequiresSource, STPPaymentIntentStatusRequiresSourceAction
danj-stripe
reviewed
Mar 13, 2019
danj-stripe
reviewed
Mar 14, 2019
…entStatusRequiresPaymentMethod instead of a STPPaymentIntentStatusRequiresSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating to accommodate some API changes https://stripe.com/docs/upgrades#2019-02-11
STPPaymentIntentsStatusRequiresSource, replaced bySTPPaymentIntentsStatusRequiresPaymentMethodSTPPaymentIntentsStatusRequiresSourceAction, replaced bySTPPaymentIntentsStatusRequiresActionSTPPaymentIntentSourceActionandSTPPaymentSourceActionAuthorizeWithURLclasses, replaced bySTPPaymentIntentActionandSTPPaymentActionRedirectToURLnextSourceActiononSTPPaymentIntent, replaced bynextActionSee https://paper.dropbox.com/doc/API-Changes-for-mid-Feb-version--AZT10970k8GfUgnOyuAeN~hOAg-PC7zkuMmx0i42AeypiP04
Testing
Reworked
STPPaymentIntentSourceActionTest->STPPaymentIntentActionTest.Updated
STPPaymentIntentFunctionalTest,STPPaymentIntentTestTo see what it would look like for a user who was still using the deprecated classes, I did the following:
STPPaymentIntentSourceActionTest, but replaced the test JSON with the new version (ie "authorize_with_url" -> "redirect_to_url")Result: The test passes, and you get warnings like this everywhere: