Rename STPPaymentIntentAction* -> STPIntentAction* #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
force-pushed
the
yuki-rename-action
branch
from
45d19a9
to
40f1942
Compare
csabol-stripe
approved these changes
Jun 27, 2019
|
|
||
| @deprecated Use `redirectToURL` instead. | ||
| */ | ||
| @property (nonatomic, strong, nullable, readonly) STPIntentActionRedirectToURL *authorizeWithURL __attribute__((deprecated("Use `redirectToURL` instead", "redirectToURL"))); |
There was a problem hiding this comment.
do we need this if we've deprecated the whole class? STPIntentAction.authorizeWithURL was never shipped
|
|
||
| NS_ASSUME_NONNULL_END | ||
| __attribute__((deprecated("Use STPIntentAction instead", "STPIntentAction"))) | ||
| typedef STPIntentAction STPPaymentIntentAction; |
There was a problem hiding this comment.
oh I see because of the typedef users may still get the drepecation from above
Stripe/STPIntentAction.m
Outdated
| @interface STPIntentAction() | ||
|
|
||
| @property (nonatomic) STPIntentActionType type; | ||
| @property (nonatomic, strong, nullable) STPIntentActionRedirectToURL* redirectToURL; |
There was a problem hiding this comment.
style-nit on the space after the * here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPPaymentIntentAction, replaced bySTPIntentActionSTPPaymentIntentActionType, replaced bySTPIntentActionTypeSTPPaymentIntentActionRedirectToURL, replaced bySTPIntentActionTypeRedirectToURLSTPPaymentIntentActionUseStripeSDKtoSTPIntentActionUseStripeSDKMotivation
In the next PRs, I'll add support for SetupIntent. This object shares these subobjects with PaymentIntent.
Testing
Leaning on existing tests.