Migrate Stripe3DS2.framework to libStripe3DS2.a #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
approved these changes
Jul 25, 2019
yuki-stripe
approved these changes
Jul 25, 2019
Stripe.xcodeproj/project.pbxproj
Outdated
| LIBRARY_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| "$(PROJECT_DIR)/InternalFrameworks", | ||
| ); | ||
| OTHER_LDFLAGS = "-ObjC"; | ||
| DEVELOPMENT_TEAM = ""; |
There was a problem hiding this comment.
Delete this line? I'm like 50% sure this makes fauxpas warn for some reason.
yuki-stripe
approved these changes
Jul 25, 2019
yuki-stripe
approved these changes
Jul 25, 2019
ghost
mentioned this pull request
|
I'm still encountering an issue with version 16.0.1 |
|
Hi @alvincrisuy, thanks for the report. We’re investigating this and should have a solution for you soon. |
wooj-stripe
pushed a commit
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes Stripe3DS2.framework in favor of a static libStripe3DS2.a.
Motivation
Nested frameworks are not allowed on the iOS App Store.
Testing