Fix STPThreeDSUICustomization not properly initializing defaults or t… #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he STDS object it's wrapping.
| _uiCustomization.labelCustomization = _labelCustomization.labelCustomization; | ||
| _uiCustomization.navigationBarCustomization = _navigationBarCustomization.navigationBarCustomization; | ||
| _uiCustomization.selectionCustomization = _selectionCustomization.selectionCustomization; | ||
| _uiCustomization.textFieldCustomization = _textFieldCustomization.textFieldCustomization; |
There was a problem hiding this comment.
so the function on line 70 is what was messing me up. Mutating the returned STPThreeDSButotnCustomization wasn't syncing. Do the above _uiCustomization setButtonCustomization calls fix that because now both dictionaries reference the same STDSButtonCustomization instance?
There was a problem hiding this comment.
Yep, exactly. _buttonCustomizationDictionary references STPThreeDSUIButtonCustomization instances which forward all their properties to the underlying STDS instance, which we are now properly setting on _uiCustomization like we should have been (like on line 67, which is why calling the setter synced things).
csabol-stripe
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he STDS object it's wrapping.
Summary
STPThreeDSUICustomizationdidn't initialize its properties to default values, and it didn't set up theSTDSobject it wraps with those default values.Motivation
😞 Sample code doesn't actually work, old behavior is not ergonomic.
Testing
Added tests for the missing behavior and tried sample code in Standard Integration app.