Add WeChat Pay support (private beta) #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for app to app redirect support.
…s. Add STPredirectContextTests
davidme-stripe
approved these changes
Aug 29, 2019
| @@ -23,6 +23,7 @@ @interface STPAPIClient (WritableURL) | |||
| @implementation STPSourceFunctionalTest | |||
|
|
|||
| - (void)setUp { | |||
| // self.recordingMode = @YES; | |||
There was a problem hiding this comment.
Seems like this was left in by mistake.
There was a problem hiding this comment.
about half of our tests have this commented for ease of re-recording 🤷♂
There was a problem hiding this comment.
I find it helpful, saves me the trouble of finding the syntax.
| @@ -316,6 +322,8 @@ - (NSString *)label { | |||
| return STPLocalizedString(@"EPS", @"Source type brand name"); | |||
| case STPSourceTypeMultibanco: | |||
| return STPLocalizedString(@"Multibanco", @"Source type brand name"); | |||
| case STPSourceTypeWeChatPay: | |||
| return STPLocalizedString(@"WeChat Pay", @"Source type brand name"); | |||
There was a problem hiding this comment.
We'll need to file a go/ask/localization ticket for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPRedirectContextMotivation
https://jira.corp.stripe.com/browse/IOS-772
https://jira.corp.stripe.com/browse/IOS-1174
Testing
STPRedirectContextTest,STPSourceFunctionalTest.testCreateSource_wechatPay