Fix Large Title support in iOS 13 #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
approved these changes
Sep 9, 2019
ramont-stripe
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Fixes checkbox having ambigous layout - this occasionally caused bad layouts when 'Billing address is same as shipping' is toggled after PaymentSheet is dismissed and reappears * Rewrite animateAlongsideKeyboard to use UIViewPropertyAnimator instead of UIView.animate * Fix curve * Update snapshot tests * Improve transition animation to autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
iOS 13 UIViewControllers in Large Title mode now have transparent backgrounds, as seen in #1350. We don't want this behavior at the moment, so we'll fill the background with the colors from the STPTheme.
Also fix cancel/edit bar buttons, as the STPTheme font wasn't propagating to all of them.
Testing
Tested in Standard Integration and UI Examples by forcing Large Title mode.