Adds updated localizations #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds localizations for English (Great Britain), Korean, Russian, and Turkish
|
Forgot to include 3ds2 sdk w/ updated strings |
davidme-stripe
approved these changes
Sep 19, 2019
| "Add a Card" = "카드 추가"; | ||
|
|
||
| /* Title for SEPA Debit Account form */ | ||
| "Add a Direct Debit Account" = "직불 카드 계좌 추가"; |
There was a problem hiding this comment.
Translating this as "Debit Card" seems off to me, as it's more of a bank transfer? Same comment for all the SEPA strings. (Maybe this is normal in Korea?)
There was a problem hiding this comment.
After googling a bit on other SEPA-supporting sites, I think this should be 자동이체 or something similar without the word "card", can we poke the translator?
There was a problem hiding this comment.
was about to reach out to localization but...turns out we don't even use this anywhere (or else it would have shown up in a screenshot sent to them). Gonna just not block for now and we can do a pass on unused keys
helzy4077
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds localizations for English (Great Britain), Korean, Russian, and Turkish
Motivation
User ask!
Testing
Generated screenshots -- sent to localization QA