Add BankSelectionViewController for FPX #1375
Conversation
| - (void)updateAppearance { | ||
| [super updateAppearance]; | ||
|
|
||
| self.tableView.allowsSelection = YES; |
There was a problem hiding this comment.
No, allowsSelection is the default, and this method was copied from another VC that doesn't seem to need it either. I'll clean that one up too.
| } | ||
|
|
||
| - (NSInteger)tableView:(__unused UITableView *)tableView numberOfRowsInSection:(__unused NSInteger)section { | ||
| return STPFPXBankBrandUnknown; |
There was a problem hiding this comment.
I'm not sure how consistent we are with always making Unknown the last item in an enumeration (hopefully we are) but 👍
There was a problem hiding this comment.
We're pretty consistent.
| @@ -23,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| @see https://stripe.com/docs/api/payment_methods/create | |||
| */ | |||
| @interface STPPaymentMethodParams : NSObject <STPFormEncodable> | |||
| @interface STPPaymentMethodParams : NSObject <STPFormEncodable, STPPaymentOption> | |||
There was a problem hiding this comment.
is this conformance needed for this PR?
There was a problem hiding this comment.
No, this was mistakenly left in from the Standard Integration support (which will be in another PR).
| [self.navigationController pushViewController:vc animated:YES]; | ||
| } | ||
|
|
||
| - (void)payWithBankAccount:(STPPaymentMethodParams *)pmParams { |
There was a problem hiding this comment.
supernit: paymentMethodParams
|
|
||
| - (void)authenticationContextWillDismissViewController:(UIViewController *)viewController { | ||
| // If we're launching directly into the SFSafariViewController for authentication from the bank selector, | ||
| // we'll want to remove the bank selector from the VC stack and pop back directly to our main controller on dismiss. |
There was a problem hiding this comment.
supernit: as a user I might not understand why we want to do this (is it necessary? what happens if I don't do it?)
Suggestion: "// remove the bank selector from the VC stack and pop back directly to our main controller on dismiss for better UX".
* Fix sending incorrect analytic for autocomplete manual entry * Update Configuration to match API review * Update address types
Summary
Adds BankSelectionViewController, which accepts a bank type and returns a PaymentMethodParams.
PaymentMethodParams is now an STPPaymentOption, and can be treated as sort of a PaymentMethod promise, allowing a user to send it directly to the Stripe API when confirming their PaymentIntent. This saves a roundtrip to the server to create separate FPX PaymentMethod, which isn't necessary as the only metadata will generally be the name of the bank.
The FPX example in Custom Integration has been modified to show how we expect developers to integrate this.
I've also added a new
authenticationContextDidPresentSafariViewControllerdelegate method to give the developer a chance to configure their view underneath the SafariViewController. This allows a developer to remove the FPX bank selector from the view controller stack while the user is handling the authentication request, providing a better experience when the payment completes. You can see an example of how this is used inFPXExampleViewController— I'm not super happy with it, but it seems like the least gross option of the options I considered. Feedback is welcome!Testing
Tested using the Custom Integration app.