Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCA + Apple Pay recommendation in docs, example code #1386

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

yuki-stripe
Copy link
Collaborator

Summary

Remove unnecessary Apple Pay + SCA code.

Motivation

https://jira.corp.stripe.com/browse/IOS-1373

Testing

Tested Apple Pay on device.
Simulator is weird, delegate method doesn't get called.

@mwoollard
Copy link

Re: the note on simulator testing of ApplePay, it broke with Xcode 10.3, worked prior to that. I've not checked Xcode 11.

Copy link
Contributor

@davidme-stripe davidme-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a comment in the linked JIRA.

@yuki-stripe yuki-stripe merged commit 2f4f6e3 into master Oct 1, 2019
@yuki-stripe yuki-stripe deleted the yuki-remove-apple-pay-sca branch October 1, 2019 18:24
ramont-stripe pushed a commit that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants